internetarchive / internetarchive/openlibrary

Some records contain null bytes in title -- 400s rendering

Open
#6,468 1 comment 0 reactions 0 assignees View on GitHub
Affects: Data Lead: @cdrini Needs: Response Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

From a patron:
The book OL26876020M and work OL19656385W seems to have a null byte in it’s title which means that the data dumps contain invalid json and also seems to make it inaccessible on the site for viewing/editing. If I could edit it myself I would but going to the book gives me a 400 bad request error because of the null: https://openlibrary.org/books/OL26876020M/Electric_and_hybrid_vehicles-Design_fundamentals_Second_edition%00
Would it be possible for you to fix that? Perhaps (and I know this is a bigger ask than just fixing this one book) to add a JSON validation (as the null is invalid in json strings) step on either imported data or on the data dump exports?

(The item has been fixed and works now, but this request is for json validation generally.)
### Evidence / Screenshot (if possible)

### Relevant url?

https://openlibrary.org/books/OL26876020M/Electric_and_hybrid_vehicles-Design_fundamentals_Second_edition%00

### Steps to Reproduce

1. Go to ...
2. Do ...

* Actual:
* Expected:

### Details

- **Logged in (Y/N)?**
- **Browser type/version?**
- **Operating system?**
- **Environment (prod/dev/local)?** prod

### Proposal & Constraints

### Related files

### Stakeholders

@cdrini

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.