internetarchive / internetarchive/openlibrary

Author merge failures (redirects, etc)

Open
#5,594 55 comments 0 reactions 0 assignees View on GitHub
Affects: Librarians Lead: @scottbarnes Module: Authors Module: Merging Needs: Response Priority: 2 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

I know there was an issue about failing author merges, but I can't find it.
### Evidence / Screenshot (if possible)

![Screen Shot 2021-08-30 at 12 06 24 PM](https://user-images.githubusercontent.com/82178/131369876-172fcff4-a413-46f1-845d-5ac19755219d.png)

### Relevant url?
https://openlibrary.org/authors/OL6736985A/Lucy_Leffingwell_Cable_Bikl%C3%A9?duplicates=OL2225567A,OL5767240A,OL6636018A,OL3665163A

### Steps to Reproduce

1. Go to the url
2. Do click it

* Actual: Error saying "That merge didn't work. It's our fault, and we've made a note of it."
* Expected: Merged author record

### Details

- **Logged in (Y/N)?**
- **Browser type/version?**
- **Operating system?**
- **Environment (prod/dev/local)?** prod

### Proposal & Constraints

In addition to fixing the bug, I'm wondering if the error message is accurate. I've received hundreds (thousands?) of these and I've never seen any action taken as a result of this "note taking." Does someone actually review these and fix them? If not, perhaps the messaging should be changed to something more accurate.

### Related files

### Stakeholders

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failure at the linked author URL in the production report, then trace the author-merge handling in the repository to identify where the redirect case fails. Done means the listed author records merge successfully and the resulting error message accurately reflects whether failures are recorded for follow-up.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.