internetarchive / internetarchive/openlibrary

Imports may be associating new Editions with /type/redirects Works

Open
#5,206 21 comments 0 reactions 0 assignees View on GitHub
Lead: @cdrini Needs: Investigation Priority: 2 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

An item on archive.org linked to this Work ID.

### Details

1. Any edition imported and attached erroneously to a `/type/redirect` work will **not** show up in search
2. We likely need to fix our Import pipeline to check first whether a work is a `/type/redirect` (and this is in something like `openlibrary/catalog/__init__.py`)
3. We likely need to clean up these http://openlibrary.org/query.json?type=/type/redirect&subjects~=*&limit=1000 <-- this will need to be pages over as there are more than 1,000 results and 1,000 is the query limit.

### Relevant url?
https://openlibrary.org/works/OL471576W?debug=true

### Steps to Reproduce

1. Go to ...https://openlibrary.org/works/OL471576W
2. Do ...observe error

* Actual: "Hmm...
Sorry. There seems to be a problem with what you were just looking at.

We've noted the error 2021-05-25/070057688265 and will look into it as soon as possible. Head for home?"
* Expected: Page loads.

### Details

- **Logged in (Y/N)?** Y
- **Browser type/version?** Version 90.0.4430.212 (Official Build) (x86_64)
- **Operating system?** Mac OS Big Sur
- **Environment (prod/dev/local)?** prod

### Proposal & Constraints

### Related files

### Stakeholders

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.