internetarchive / internetarchive/openlibrary

Dockerfile openlibrary user should have fixed UID/GID

Open
#4,191 0 comments 0 reactions 0 assignees View on GitHub
Affects: Configuration Lead: @cdrini Module: Docker Needs: Investigation Priority: 3
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

Our olbase Dockerfile creates an `openlibrary` user and group. These are assigned a new ID automatically by the container's OS. However this ID can conflict with users that exist on the host OS, creating potential security holes (I think?). Let's pick a UID/GID and specify it when creating the users in the container, and also let's do the same on the host machines in our provisioning scripts. (Which _I believe_ is the best practice?? Or maybe we only need this if we're mounting host folders onto the container, like we did for covers?)

## Stakeholders

@traceypooh

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.