internetarchive / internetarchive/openlibrary
Multiple redundant memcached updates
- Dominant language
- Python
- Stars
- 6.7k
- Forks
- 2k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 138
Description
In the logs for memcached, I'm seeing four identical update commands of the following form:
`set home.ia_carousel_books--{"_type":"authors","limit":42,"query":null,"sorts":null,"work_id":"/works/OL53924W","subject":null} 0 0 22`
when editing / fetching and edition page `/books/OL24197475M`.
There are also four gets for
`get /books/OL5917026M /books/OL24237305M /books/OL4443330M /books/OL13633477M /books/OL6221549M /books/OL26555556M /books/OL26401864M /books/OL26328999M /books/OL796659M /books/OL7432606M /books/OL4884830M /books/OL5994211M /books/OL6250285M /books/OL6500347M /books/OL9690649M /books/OL6191960M /books/OL16284648M /books/OL5076270M /books/OL5621861M /books/OL23253222M /books/OL7822224M /books/OL4726015M /books/OL6251026M /books/OL24222339M /books/OL6282875M /books/OL12868589M /books/OL26430710M /books/OL8142850M /books/OL2211006M /books/OL11130785M /books/OL6247951M /books/OL6113024M /books/OL22100039M /books/OL8931527M /books/OL25845700M`
The whole thing looks generally suspicious and should be reviewed.
Contributor guide
Research direction
Start by reproducing the memcached commands while editing or fetching edition page /books/OL24197475M, then trace where the repeated updates and gets are issued. Review the cache call path around this page; done means redundant identical commands are eliminated and the page still loads correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100