internetarchive / internetarchive/openlibrary

API should reject edits with no changes

Open
#1,903 2 comments 0 reactions 0 assignees View on GitHub
Affects: Server Lead: @jimchamp Needs: Breakdown Needs: Investigation Priority: 3 Theme: Editing Theme: Public APIs Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

## Description

Due to a front end bug, the backend was given an "edit" request which didn't actually change anything. The backend API should reject any requests which result in no changes.

## Evidence

https://dev.openlibrary.org/books/OL23271756M/Soul_made_flesh?b=10&a=9&_compare=Compare&m=diff

## Details

In this particular case, there were two corresponding edits which consisted solely of bumping the version number for the related entity, neither of which had any actual changes.

https://dev.openlibrary.org/books/OL23271756M.json?m=history
https://dev.openlibrary.org/works/OL13699253W.json?m=history

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.