internetarchive / internetarchive/openlibrary

Pager missing from patron edit history (admin view)

Open
#13,647 0 comments 0 reactions 0 assignees View on GitHub
Needs: Breakdown Needs: Investigation Needs: Lead Needs: Staff / Internal Needs: Triage Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

Sometimes a number of patron edits must be reverted. This can be done at https://openlibrary.org/admin/people/PATRON/edits. Often the edits to be reviewed span multiple pages. However the pager is just forward/backward arrows. No way to go to a specific page. Additionally, only one page can be actioned at a time (I think). So if the edits are selected and reverted, the page returns to the beginning. One must keep track of which page they left off on and re-navigate to the page.

Image

### Reproducing the bug

1. Go to ... https://openlibrary.org/admin/people/PATRON/edits (PATRON is a placeholder)
2. Do ... Try to revert edits on multiple pages

* Expected behavior: When saved return to the page being edited, or at least provide a pager so it's easy to navigate back to the last actioned page.
* Actual behavior: After submitting changes one is navigated back to the starting page.

### Context

- Browser (Chrome, Safari, Firefox, etc):
- OS (Windows, Mac, etc):
- Logged in (Y/N):
- Environment (prod, dev, local): prod

### Breakdown

Implementation Details (for maintainers)

#### Requirements Checklist
* [ ]

#### Related files

*

#### Stakeholders

*


#### Instructions for Contributors

- Please [run these commands](https://docs.openlibrary.org/developers/tools/git.html#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://docs.openlibrary.org/developers/tools/git.html#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Research direction

Open the admin patron edits page at /admin/people/PATRON/edits and reproduce reverting edits across multiple pages. Trace the page's pager and form submission flow, then verify that navigation returns to the edited page or provides direct page navigation after saving.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.