internetarchive / internetarchive/openlibrary

Unable to select text of author's name on edition page after author "button" accidentally clicked

Open
#13,618 2 comments 0 reactions 0 assignees View on GitHub
Affects: Librarians Affects: UI Lead: @cdrini Module: Integrated Librarian Environment (ILE Bar) Module: JavaScript Needs: Breakdown Needs: Response Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

While creating #13617, I discovered that it's possible to get the page into a state where it's impossible to select the text associated with the author's name in the link.

### Reproducing the bug

1. Go to https://openlibrary.org/books/OL60300732M
2. (Accidentally) click blue dot next to author's name
3. Attempt to select text of edition title and author's name
4. Click "Clear selections" on omni bar
5. Attempt to select text again

* Expected behavior: Edition title and author's name gets selected together as a single string of text
* Actual behavior: author's name is silently skipped in both cases, even after the little magic button is deselected

### Context

- Browser (Chrome, Safari, Firefox, etc): Chrome
- OS (Windows, Mac, etc): Mac
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod

### Breakdown

Implementation Details (for maintainers)

#### Requirements Checklist
* [ ]

#### Related files

*

#### Stakeholders

* @lokesh


#### Instructions for Contributors

- Please [run these commands](https://docs.openlibrary.org/developers/tools/git.html#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://docs.openlibrary.org/developers/tools/git.html#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue on the edition page at https://openlibrary.org/books/OL60300732M in Chrome, including clicking the blue dot beside the author and using “Clear selections.” Trace the edition title and author-name selection behavior; done means the title and author name can be selected together both before and after clearing selections.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.