internetarchive / internetarchive/openlibrary

Fix excessive-permissions violations and re-enable zizmor audit (follow-up to #13411)

Open
#13,435 1 comment 0 reactions 0 assignees View on GitHub
Affects: CI/CD Affects: Configuration Lead: @RayBB Needs: Staff Decision Priority: 2 Theme: Development
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

#13411 added zizmor but globally disabled the `excessive-permissions` rule in `.github/zizmor.yml` (`disable: true`, currently suppressing 73 findings, no rationale comment).

Work:
- [ ] Add top-level `permissions: {}` defaults + explicit job-level grants to each workflow
- [ ] Remove the global disable from `.github/zizmor.yml` (and annotate with tracking link until then)

Contributor guide

Open the contributing guide

Research direction

Inspect the workflow files under .github and .github/zizmor.yml, starting with the disabled excessive-permissions rule and the 73 suppressed findings. Run the zizmor audit while reviewing each job's required access; done means top-level empty permissions, explicit job-level grants, and the global disable removed with the audit passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, yaml
Domain
ci-cd, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.