internetarchive / internetarchive/openlibrary
Tracking sqlfluff issue fixes to remove remaining files from pre-commit exclusion
- Dominant language
- Python
- Stars
- 6.7k
- Forks
- 2k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 138
Description
We removed `scripts/solr_builder/sql/prod-partial-dump.sql` exclusion from the `exclude` list in `.pre-commit-config.yaml` in PR #12243 closing #11919
But the `scripts/solr_builder/sql/import-partial.sql ` and `scripts/dev-instance/patron_data.sql` cannot be excluded until sqlfluff/sqlfluff#7696 and sqlfluff/sqlfluff#7697 are fixed.
After the fix we can :
- Update the new sqlfluff version.
- And remove `scripts/dev-instance/patron_data.sql` and `scripts/solr_builder/sql/import-partial.sql` from the `exclude` list in `.pre-commit-config.yaml`.
Releases: https://github.com/sqlfluff/sqlfluff/releases
Contributor guide
Research direction
Check sqlfluff issues #7696 and #7697 and the sqlfluff releases first to confirm the required fixes are available. Then inspect .pre-commit-config.yaml and the two listed SQL paths, update the sqlfluff version, and remove both paths from the exclude list. Run pre-commit against those files to verify they are no longer excluded and pass linting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sql, yaml
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100