internetarchive / internetarchive/openlibrary

Dry up rendering of book provider `download` options to only use one download options html

Open
#11,274 5 comments 0 reactions 1 assignee Claimed by @Ritesh-251 View on GitHub
Lead: @cdrini Priority: 3 Theme: Trusted Book Providers Type: Refactor/Clean-up
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

Currently we have a separate download option for each trusted book provider:

* openlibrary/templates/book_providers/librivox_download_options.html
* openlibrary/templates/book_providers/ia_download_options.html
* openlibrary/templates/book_providers/openstax_download_options.html
* and so on

Now that we have normalized `AbstractBookProvider.get_acquisitions`, we want to replace these with `book_providers/download_options.html` template, that simple renders the relevant acquisitions.

https://github.com/internetarchive/openlibrary/blob/406e76766447c831af237a4100f3e6d52450d965/openlibrary/book_providers.py#L276-L283

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.