internetarchive / internetarchive/openlibrary

Can't limit subject carousel to a specific year

Open
#10,971 4 comments 0 reactions 0 assignees View on GitHub
Lead: @jimchamp Needs: Breakdown Priority: 3 Type: Bug
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Problem

Previously, you could press on a certain year in a Publishing History graph and it would limit carousels to only works that have editions from this year. Now this does not work, it just shows all the works

https://openlibrary.org/subjects/comics_&_graphic_novels_manga_science_fiction

### Reproducing the bug

1. Go to any subject page
2. Do ... press on any year of Publishing History graph

* Expected behavior: carousel gets limited to contain only works/editions from this year
* Actual behavior: carousel reloads and still shows all the works

### Context

- Browser (Chrome, Safari, Firefox, etc): Firefox
- OS (Windows, Mac, etc): Linux Mint
- Logged in (Y/N): Y
- Environment (prod, dev, local): prod

### Breakdown

#### Requirements Checklist
* [ ]

#### Related files

*

#### Stakeholders

*


#### Instructions for Contributors

- Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.