internetarchive / internetarchive/openlibrary
Editions table filter does not work when ISBN 10 and ISBN 13 aren't equivalent
- Dominant language
- Python
- Stars
- 6.7k
- Forks
- 2k
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 126
Description
### Problem
Filtering an ISBN 10 on the editions table does not return the correct result if the ISBN 13 is not a correct match.
`
0340153660 9780340153666
### Reproducing the bug
1. Go to ...https://openlibrary.org/books/OL5447284M/Event_1000?v=11 and restore version 11
2. Do ... filter 0030859697 on the editions table
* Expected behavior: If the ISBN is present, it should appear, regardless of any other ISBN present.
* Actual behavior: If an ISBN 13 is present and is not the correct equivalent, no results are returned.
### Context
- Browser (Chrome, Safari, Firefox, etc):
- OS (Windows, Mac, etc):
- Logged in (Y/N):
- Environment (prod, dev, local): prod
### Breakdown
#### Requirements Checklist
* [ ]
#### Related files
*
#### Stakeholders
*
#### Instructions for Contributors
- Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
Contributor guide
Research direction
Start by reproducing the issue at the linked book page, restore version 11, and filter the editions table with 0030859697. Trace the editions-table ISBN filtering path and add coverage for a present ISBN 10 whose ISBN 13 is not an equivalent match. Done means the matching edition appears without requiring the other ISBN to match.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100