internetarchive / internetarchive/openlibrary
Goodreads import fails with poor explanation
- Dominant language
- Python
- Stars
- 6.7k
- Forks
- 2k
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 138
Description
### Problem
After importing a Goodreads csv file, some items display error "Failed to add book to reading log" even though the import itself was successful. This gives little feedback on how to fix the issue.
### Reproducing the bug
1. Go to ...https://openlibrary.org/account/import
2. Do ...import a csv file
* Expected behavior: Items that are successfully imported should also be added to the reading log.
* Actual behavior: Errror as noted above.
### Context
- Browser (Chrome, Safari, Firefox, etc):
- OS (Windows, Mac, etc):
- Logged in (Y/N):
- Environment (prod, dev, local): prod
### Breakdown
#### Requirements Checklist
* [ ]
#### Related files
*
#### Stakeholders
*
#### Instructions for Contributors
- Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
Contributor guide
Research direction
Start at the /account/import entry point and reproduce the issue with a Goodreads CSV file. Trace the import and reading-log steps using the issue's expected and actual behavior as acceptance criteria; done means successfully imported items are added to the reading log and failures provide useful feedback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100