internetarchive / internetarchive/openlibrary

Remove residual references to subject objects

Open
#1,042 2 comments 0 reactions 0 assignees View on GitHub
Lead: @cdrini Module: Solr Priority: 3 Type: Refactor/Clean-up
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

At some point we had subjects stored as objects, like:

```json
{
"key" : "/works/OL167326W",
"subjects" : [{"key" : "/subjects/Large_type_books"},{"key" : "/subjects/Fiction"},{"key" : "/subjects/Women"},{"key" : "/subjects/Women_lawyers"}],
}
```

No records like this exist any more, so the code no longer has to worry about it. I think some of the solr updating code checks for this; it can be updated (and possibly others).

Contributor guide

Open the contributing guide

Research direction

The issue names the Solr updating code but no specific file or test; begin by searching that code for checks handling subject objects, then inspect any other references found. Done means the obsolete object-form subject handling is removed wherever the search identifies it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.