internetarchive / internetarchive/openlibrary

Have a list of work titles that will avoid conflation on edition title mismatch

Open
#10,342 8 comments 1 reaction 0 assignees View on GitHub
Lead: @scottbarnes Module: Import Priority: 3 Type: Feature Request
Dominant language
Python
Stars
6.7k
Forks
2k
Avg merge
2d 19h
Merged PRs (30d)
138

Description

### Proposal

There are certain cases of works which we want to exclude imported editions/works from joining. For example:

- Generic titles like "Bill" / "Law" ( although I'm not sure we import these anymore )
- Certain series names, like "The Diary of a Wimpy Kid"
- Certain biographical books like "Picasso"

(links welcome please, was having trouble finding the exact examples I've seen in the past)

There aren't a _ton_ of works in this category ; and although having a more systemic solution to the problem would be ideal, perhaps having a temporary solution that's just a list that makes the resolution process for these works more strict will be a boon.

We noticed while investigating some old code in https://github.com/internetarchive/openlibrary/pull/10336#discussion_r1916885894 that there was a code path there that _tried_ to do something like this, but which due to a logic bug never actually did anything at all. The idea behind it is sound/useful though.

### Justification

### Breakdown

#### Requirements Checklist

* [ ]

#### Related files

*

#### Stakeholders

*


#### Instructions for Contributors

Please [run these commands](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#working-on-your-branch) to ensure your repository is up to date **before** [creating a new branch](https://github.com/internetarchive/openlibrary/wiki/Git-Cheat-Sheet#making-changes-and-creating-a-pull-request) to work on this issue and **each time after** pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.