internetarchive / internetarchive/openlibrary-client

Editions with wikidata, bookbrainz, and other new identifiers breaks save()

Open
#422 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
506
Forks
110
PR merge metrics
No merged PRs in 30d

Description

```
[/usr/local/lib/python3.11/dist-packages/olclient/common.py](https://localhost:8080/#) in _validate_identifiers(identifiers)
28 for id_type, values in identifiers.items():
29 if id_type not in VALID_IDENTIFIERS:
---> 30 raise AttributeError(
31 f"ID type '{id_type}' is not one of {VALID_IDENTIFIERS}"
32 )

AttributeError: ID type 'wikidata' is not one of ('olid', 'oclc', 'isbn_10', 'isbn_13', 'isbns', 'lccn', 'goodreads', 'librarything')
```

![Image](https://github.com/user-attachments/assets/7cb799b9-2e9b-4ee4-bb7e-e078e04e9cb1)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.