internetarchive / internetarchive/openlibrary-bots

Create an ONIX-bot for Bibliometa data-set

Open
#12 0 comments 0 reactions 1 assignee Claimed by @sbshah97 View on GitHub
ONIX bot
Dominant language
Python
Stars
81
Forks
67
PR merge metrics
No merged PRs in 30d

Description

References https://github.com/internetarchive/openlibrary/issues/860

In addition to the two bug fixes mentioned up top, there are a whole stack of other things that need to be cleaned up since this code hasn't been touched in 9 years. It may even be the case that it's better to use the current code as a specification and reimplement.

Some of the things which I notice at a glance:

- [x] PEP-8 spaces instead of tabs (Use pycodestyle for this)
- [x] replace Sax with ElementTree or other modern XML access
- [ ] replace xmltramp.py with a more modern off-the-shelf XML library
- [ ] replace urlcache.py with Requests cache? May be built-in to XML library, so unnecessary
- [ ] replace thread_utils.py with modern built-ins
- [ ] define a custom exception to raise rather than using Exception
- [ ] names are converted to ASCII (ick! perhaps one of the sources of all our broken names)
- [ ] importer works directly against a database instead of using the API

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.