internetarchive / internetarchive/dweb-gateway

Escaping of urls in search

Open
#41 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
20
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Noticed that
[https://dweb.me/arc/archive.org/advancedsearch?output=json&q=mediatype%3A(Texts)%20AND%20contributor%3A(Lewis%20%26%20Clark%20Community%20College%20and%20the%20National%20Great%20Rivers%20Research%20and%20Education%20Center)&rows=30&page=1&sort[]=-downloads&and[]=undefined&save=yes]
doesn't work, but
[https://archive.org/advancedsearch.php?output=json&q=mediatype%3A(Texts)%20AND%20contributor%3A(Lewis%20%26%20Clark%20Community%20College%20and%20the%20National%20Great%20Rivers%20Research%20and%20Education%20Center)&rows=30&page=1&sort[]=-downloads&and[]=undefined&save=yes]
works fine.

Looks like the wrong combination of urldecoding and urlencoding is happening in the Python Gateway,

Note this is coming from the query encoded in [https://dweb.archive.org/metadata/lewis_and_clark]

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the Python Gateway code that builds search URLs from the query in https://dweb.archive.org/metadata/lewis_and_clark. Compare the generated dweb.me URL with the working archive.org URL, then verify that encoding and decoding are preserved so the search request works as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.