internetarchive / internetarchive/bookreader

Handle invalid JSON in search result responses

Open
#759 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.2k
Forks
491
Avg merge
2d 15h
Merged PRs (30d)
3

Description

The search endpoint can sometimes error and return invalid JSON. The search plugin should be resilient to this. Note that it _is_ making a JSONP request, so invalid JSON in this case would result in invalid JS, meaning jquery's callback won't be called, so it might not be possible to handle this, but it might be the case that the `onerror` event on the `` is forwarded by jQuery? Some investigation needed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.