internetarchive / internetarchive/bookreader

Page turner progress bar should move leftward for RTL books

Open
#580 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.2k
Forks
491
Avg merge
2d 15h
Merged PRs (30d)
3

Description

**Description**

(With much appreciation to @Pyrojet99 , @iisa, and others I don't know of who have worked to make RTL reading a good experience! ... ) Although the arrow buttons, arrow keys, and page turning animation all match the reading direction for right-to-left books, the progress bar on the bottom does not. It moves _rightward_ as the reader progresses through the book _leftward_.

**Evidence / Screenshot (if possible)**

Screen Shot 2020-12-21 at 10 15 52 PM
From https://archive.org/details/gendaitankashu00meijuoft/page/27/mode/2up

**Expectation**

For RTL books,
- the progress bar should begin on the right for page 1 and move leftward as page numbers increase
- dragging the progress bar handle leftward should increase the page numbers, rightward should decrease them
- clicking to the left of the progress bar handle should jump to a later page, clicking to its right should jump to an earlier page

**Context**

FF 84.0 on Mac 10.14.6

**Proposal & Constraints**

?

**Stakeholders**

@right2leftdh

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.