internetarchive / internetarchive/bookreader

Test for undefined Bookreader components (e.g. $BRnav)

Open
#162 1 comment 0 reactions 0 assignees View on GitHub
difficulty: medium priority: high
Dominant language
JavaScript
Stars
1.2k
Forks
491
Avg merge
2d 15h
Merged PRs (30d)
3

Description

**Description**

re: #161

In certain cases where no nav bar is present for a book (e.g. a book w/ admin privileges w/ no preview), we can’t expect a nav bar to appear, causing `br.refs.$BRnav` to be `undefined`.

> What problem are we solving? What does the experience look like today? What are the symptoms? How can one reproduce the problem?

**Evidence / Screenshot (if possible)**

> Include evidence of the problem or provide a screenshot.

The bookreader won't fully load due to js error halting execution. In today's regression case, the "admin" bar failed to load (which allows users to QA a book). This is a mission critical use case for our scanning centers to do QA and so such an admin privileged book should be included in our testing:

https://archive.org/details/alopeciaareata0000levy

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.