internetarchive / internetarchive/bookreader

Typo in a constructor property

Open
#1,301 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.2k
Forks
491
Avg merge
2d 15h
Merged PRs (30d)
3

Description

**Description**

In the file ``search-results.js`` which is inside ``src/BookNavigator/search/search-results.js`` there is a typo. In the **IABookSearchResults** class, there is a property named ``renderSearchAllFields`` in the constructor, but the correct property name is ``renderSearchAllFiles`` according to the static properties definition.

**Evidence / Screenshot (if possible)**
![image](https://github.com/internetarchive/bookreader/assets/110035752/7f3842ee-03f9-46f1-9999-8cde68182876)

**Expectation**

Instead of:
```js
this.renderSearchAllFields = false;
```
It should be:

```js
this.renderSearchAllFiles = false;
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.