internetarchive / internetarchive/bookreader

typographic quotemarks and text search on iPad

Open
#1,070 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.2k
Forks
491
Avg merge
2d 15h
Merged PRs (30d)
3

Description

**Description**

> What problem are we solving? What does the experience look like today? What are the symptoms? How can one reproduce the problem?
With a book opened, on a windows browser you can search for a phrase using quotemarks ("word1 word2"); the typewriter straight marks on the keyboard. E.g search of "lives down" in this book:
https://archive.org/details/zuluheart00barn/page/n6/mode/2up?q="lives+down"
2 results.

On an iPad, using Chrome, type the same search and iPad automatically makes the quotemarks left and right typographic quotes.
https://archive.org/details/zuluheart00barn/page/n6/mode/2up?q=“lives+down”
Now we have 188 results, the words are not grouped.

**Evidence / Screenshot (if possible)**

> Include evidence of the problem or provide a screenshot.

**Expectation**

> What should be happening? What will it look like / how will it behave when fixed?

Should convert typographic quotes into typewriter on input to search so phrases can be searched for.

**Context**

> What operating system? What browser type and version?
iPad, Chrome current version and probably any other browser on iPad
**Proposal & Constraints**

> What is the proposed solution / implementation? Is there a precedent of this approach succeeding elsewhere?
In search box convert typographic double quotes into typewriter marks. Probably also single quotes(')

**Stakeholders**

> @-tag any stakeholders of this bug

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.