intermine / intermine/bluegenes

Consider not passing model when invoking tool main functions

Open
#759 0 comments 0 reactions 0 assignees View on GitHub
performance Tool API
Dominant language
Clojure
Stars
75
Forks
59
PR merge metrics
No merged PRs in 30d

Description

Traditionally, the model has been passed to Bluegenes Tools on invocation (see `src/cljs/bluegenes/components/tools/effects.cljs`) but I don't think any tool developed so far use it and I don't think it's documented either.

It might be worth it to do `select-keys [:root :token]`

Contributor guide

Open the contributing guide

Research direction

Start in src/cljs/bluegenes/components/tools/effects.cljs and trace how the model is passed when tool main functions are invoked. Check the available tool implementations and documentation to confirm whether the model is used or described. Done means the invocation passes only the intended keys and the behavior is covered by the relevant existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.