intel / intel/rohd

`Module.uniqueInstanceName` not enforced as reserved name in `Synth` stack

Open
#610 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Dart
Stars
489
Forks
88
Avg merge
3d 23h
Merged PRs (30d)
10

Description

### Describe the bug

The `Module.uniqueInstanceName` is supposed to be a guaranteed unique name for an instance in the context of a module hierarchy. This is nice for debug and waveform viewing, but doesn't come with guarantees on generated outputs.

We should fix the `Synth` stack so that when outputs are generated, the instance names of modules are guaranteed to be equal to the `uniqueInstanceName`. This does mean that if someone tries to reserve another name that would conflict with an auto-selected unique instance name, it will fail on the other reserved name. Since this happens during build, perhaps we can first check for reserved internal signal names to avoid such conflicts.

### To Reproduce

_No response_

### Expected behavior

_No response_

### Actual behavior

_No response_

### Additional: Dart SDK info

_No response_

### Additional: pubspec.yaml

```yaml

```

### Additional: Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.