intel / intel/rohd-hcl

StaticOrRuntimeParameter does not check for name on Runtime Logic signal

Open
#235 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Dart
Stars
115
Forks
39
Avg merge
1d 13h
Merged PRs (30d)
1

Description

### Describe the bug

When passing a Logic() as a parameter to configure additional hardware in a component, the StaticOrRuntimeParameter class must add an input and it uses the name of the Logic with which it was constructed to declare the input. But if the Logic has no name, then this will fail.

### To Reproduce

```dart
CompressionTreeMultiplier(Logic(), Logic(), signedMultiplicand: Logic(), signedMultiplier: Logic())
```

This will fail when creating signal inputs for the two parameters.

### Expected behavior

_No response_

### Actual behavior

_No response_

### Additional: Dart SDK info

_No response_

### Additional: pubspec.yaml

```yaml

```

### Additional: Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.