intel / intel/rohd-hcl

RoundRNE is not rounding to even, both logic and value side

Open
#190 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Dart
Stars
115
Forks
39
Avg merge
1d 13h
Merged PRs (30d)
1

Description

### Describe the bug

While the FP components match our conversion from double with rounding, the rounding algorithm is not truly RNE. RNE needs to consider the mantissa width; it looks like it is working correctly for odd lengths but not even.

### To Reproduce

The bug won't reproduce on 32-bit because the RoundRNE is correct for odd mantissa lengths. So it needs to be validated by inspection and modifying both the value side and the logic side together.

### Expected behavior

_No response_

### Actual behavior

_No response_

### Additional: Dart SDK info

_No response_

### Additional: pubspec.yaml

```yaml

```

### Additional: Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.