intel / intel/rohd-bridge

The default for `connect` and order of arguments are different on `addPortMap` for `BridgeModule` and `InterfaceReference`

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Dart
Stars
13
Forks
5
Avg merge
19h 29m
Merged PRs (30d)
7

Description

### Describe the bug

It's confusing to have a different default and positional argument order between two effectively identical functions on different classes (one calls the other). These should be made consistent.

```
// in BridgeModule
PortMap addPortMap(PortReference port, InterfacePortReference intfPort,
{bool connect = false}) =>

// in InterfaceReference
PortMap addPortMap(InterfacePortReference interfacePort, PortReference port,
{bool connect = true}) {
```

This would be a *breaking change*, unfortunately

### To Reproduce

_No response_

### Expected behavior

_No response_

### Actual behavior

_No response_

### Additional: Dart SDK info

_No response_

### Additional: pubspec.yaml

```yaml

```

### Additional: Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.