intel / intel/pti-gpu

ompt_callback_target_data_op_t strange behavior

Open
#16 6 comments 0 reactions 1 assignee Claimed by @TApplencourt View on GitHub
Dominant language
C++
Stars
273
Forks
70
PR merge metrics
No merged PRs in 30d

Description

Not really a bug in PTI (because it produce correct results) maybe more a bug in the implementation in `icpx`.
You seem to be the POC for this kind of bug. Sorry :)

Official headers for OpenMP tools say
```
typedef void (*ompt_callback_target_data_op_t)(
ompt_id_t target_id, ompt_id_t host_op_id, ompt_target_data_op_t optype,
void *src_addr, int src_device_num, void *dest_addr, int dest_device_num,
size_t bytes, const void *codeptr_ra);
```
https://github.com/OpenMP/sources/blob/eb82823fda8b3ead31da8a517946d9219b41f440/include/omp-tools.h#L692-L695

Where in PTI you are prepending an `ompt_scope_endpoint_t endpoint` to the argument list
https://github.com/intel/pti-gpu/blob/6e18132fafaff41fff306a0a0421fbadfd01697a/samples/omp_hot_regions/tool.cc#L73-L78

Strangely enough, this "non-OpeMP 5.2 compliant" parameters list seems needed to get correct results with public `icpx/omp runtime`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.