intel / intel/opencl-intercept-layer

update CMake threads behavior

Open
#471 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
369
Forks
90
Avg merge
15h 13m
Merged PRs (30d)
10

Description

See: https://cmake.org/cmake/help/latest/module/FindThreads.html

We should make a few small updates to modernize the CMake threads behavior:

1. We should use the `Threads::Threads` target vs. `${CMAKE_THREAD_LIBS_INIT}`.
2. We should investigate whether we should set `THREADS_PREFER_PTHREAD_FLAG` to `TRUE`.

Contributor guide

Open the contributing guide

Research direction

Start with the repository's CMake build configuration and read the linked FindThreads documentation. Locate uses of CMAKE_THREAD_LIBS_INIT, compare them with the Threads::Threads target, and investigate whether THREADS_PREFER_PTHREAD_FLAG should be enabled. Done means the modernized behavior is applied consistently and the project still configures and builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.