intel / intel/numatop

function ll_init() is not initializing some fields in cfg

Open
#59 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
212
Forks
50
Avg merge
54m
Merged PRs (30d)
1

Description

In common/os/os_perf.c function ll_init() is declaring cfg on the stack and then assigning conf from some uninitialized fields in cfg namely:

```
839 conf->type = cfg.type;
840 conf->config = (cfg.config) | (cfg.other_attr << 16);
841 conf->config1 = cfg.extra_value;
```

Should cfg be memset before calling plat_ll_config?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.