Сonsider building a debug configuration for Windows-specific precommit testing.
Open
confirmed
enhancement
infrastructure
- Dominant language
- LLVM
- Stars
- 1.5k
- Forks
- 854
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 137
Description
Don't let me hold anything up in this space, but one thing to consider for Windows-specific precommit testing is to build a debug configuration so that we get checked & debug iterator testing (https://learn.microsoft.com/en-us/cpp/standard-library/safe-libraries-cpp-standard-library?view=msvc-170). That helps catch quite a few mistakes (I just fixed one this morning that turned out to be `A.find(X) != B.end()` where `A` and `B` are the same type but different objects -- MSVC debug iterators caught the issue immediately).
_Originally posted by @AaronBallman in https://github.com/intel/llvm/issues/8980#issuecomment-1502040376_
Contributor guide
Assessment
This issue has not been assessed yet.