intel / intel/llvm

Define pass to hold `scf` (and other dialects) canonicalization patterns defined in `polygeist`

Open
#8,700 0 comments 0 reactions 1 assignee Claimed by @victor-eds View on GitHub
enhancement sycl-mlir
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

**Is your feature request related to a problem? Please describe**

Currently, `polygeist` defines some canonicalization patterns for operations defined in other dialects, so, if `polygeist` isn't loaded, these won't be loaded and won't be applied.

**Describe the solution you would like**

We should define a pass instead and apply the patterns that way.

**Describe alternatives you have considered**

Define canonicalization patterns in their respective dialects, but this would make us diverge from upstream.

**Additional context**

This began failing [in this PR](https://github.com/intel/llvm/pull/8692), which exposed this flaw as we got ready for dropping the deprecated feature.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.