intel / intel/llvm

Investigate flaky assert tests for HIP

Open
#6,520 0 comments 0 reactions 0 assignees View on GitHub
bug hip
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

The following PR introduced an implementation of assert for HIP
* https://github.com/intel/llvm/pull/6424

And the assert tests were re-enabled in:

* https://github.com/intel/llvm-test-suite/pull/1083

Locally none of the tests were failing so we went ahead and merged the changes but later on in:

* https://github.com/intel/llvm/pull/6519

One of the assert test failed in the CI.

This is likely similar to the issue for CUDA in https://github.com/intel/llvm/issues/6416 however for HIP the same workaround are not applicable because the HIP runtime is aborting before it reaches the PI plugin so the failure isn't with host output we control. In addition in the CI the test seems to be crashing so it's unclear if this is a garbled output.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.