intel / intel/llvm

Why are incorrect attributes attached to redeclarations

Open
#5,816 0 comments 0 reactions 1 assignee Assigned to @smanna12 View on GitHub
confirmed
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

This note diagnostic is what raised concern for me. I don't know if it should be on the last 'correct' declaration instead of an incorrect one. Anyway like I said - we don't need to worry about it in this patch.

_Originally posted by @elizabethandrews in https://github.com/intel/llvm/pull/5535#r827156451_

Looks like incorrect attributes are attached to redeclaration instead of skipping. Investigate why. Should we be dropping attribute instead of returning nullptr in merge logic?

AST dump of invalid declarations show attribute attached.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.