intel / intel/llvm

Remove usages of `opencl_constant` attribute from DPC++ library headers

Open
#3,062 1 comment 0 reactions 0 assignees View on GitHub
upstream
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

The patch adding [address space attributes ](https://reviews.llvm.org/D89909) to llvm-project repository doesn't support `opencl_constant` attribute and using this attribute in DPC++ headers leads to the crash ([here](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaType.cpp#L6489)).

In particular this attribute is defined in https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/access/access.hpp#L116 and used:
- in internal template function specialization https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/access/access.hpp#L222-L225 (should be quite easy to remove)
- for `printf` extension https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/ONEAPI/experimental/builtins.hpp#L13-L17 and https://github.com/intel/llvm/blob/sycl/sycl/include/CL/sycl/ONEAPI/experimental/builtins.hpp#L62 (additional work is required to emit valid SPIR-V module).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.