intel / intel/llvm

Deprecate SYCL 1.2.1 image related stuff and prepare for removal

Open
#22,539 3 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

### Describe the bug

Recently I've deprecated the `image` class, but actually there is still a lot of image related stuff, that should be **deprecated**.

Need to deprecate:
```
class sampler
access::target::image
access::target::host_image
access::target::host_array
```

Also need to remove the `SYCL_DISABLE_IMAGE_ASPECT_WARNING` macro from source files and from [PreprocessorMacros.md](https://github.com/intel/llvm/blob/sycl/sycl/doc/PreprocessorMacros.md?plain=1#L37)

### To reproduce

1. Include a code snippet that is as short as possible
2. Specify the command which should be used to compile the program
3. Specify the command which should be used to launch the program
4. Indicate what is wrong and what was expected

### Environment

- OS: [e.g Windows/Linux]
- Target device and vendor: [e.g. Intel GPU]
- DPC++ version: [e.g. commit hash or output of `clang++ --version`]
- Dependencies version: [e.g. the output of `sycl-ls --verbose`]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Search the SYCL source tree for the sampler, access::target image-related targets, host_array, host_image, and SYCL_DISABLE_IMAGE_ASPECT_WARNING references. Review PreprocessorMacros.md at the linked entry, then deprecate the listed APIs and remove the macro references; done means the intended deprecations are present and the macro is absent from source and documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, documentation
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.