intel / intel/llvm

Rename alloca... to something else in the SYCL runtime

Open
#1,927 3 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

In Unix `alloca()` means something very precise for 40+ years and it is also used inside LLVM IR as a specific instruction https://llvm.org/docs/LangRef.html#alloca-instruction
In this SYCL implementation it is used all over the place in the runtime as a shortcut for allocation.
While `alloca()` is about allocation too, it is super misleading.
Every time time I look at a PR here with "alloca" I get bitten.
I mentioned this several times already in the past in some reviews but now I think it should be updated before it spreads too much or is vetoed during up-streaming.
"alloc" could be a good trade-off, if "allocation" is too long.
Just no "alloca" when it is not about `alloca()`. :-)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.