intel / intel/llvm

Base64::encode/decode is not standard base64 enconding

Open
#14,729 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
LLVM
Stars
1.5k
Forks
854
Avg merge
3d 17h
Merged PRs (30d)
137

Description

### Describe the bug

The[ `Base64::encode`/`decode` ](https://github.com/intel/llvm/blob/67fa0848e4e67ae2b93d2008328f97da35aa9574/llvm/include/llvm/Support/Base64.h#L64) methods, which are used to encode binary data in the `.prop` files used by `sycl-post-link`, is not the standard base64 encoding (RFC 4648): `Base64::encode("hello world", ...)` gives `oVGbs9GI39mcsRG` while standard base64 encodes this as `aGVsbG8gd29ybGQ=`. The pair of methods do not seem to be flawed in the case of a being able to encode/decode successfully, but this makes it awkward and confusing to make new `sycl-post-link` tests checking the output of the `.prop` files, as they use a nonstandard encoding.

### To reproduce

_No response_

### Environment

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.