Some basic tests should be gated when not configured with --cuda or --hip
- Dominant language
- LLVM
- Stars
- 1.5k
- Forks
- 854
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 137
Description
**Describe the bug**
The CI runs by default with --cuda --hip configuration which hides some bugs when not compiling with these options.
https://github.com/intel/llvm/actions/runs/7107844414/job/19350224693?pr=12087#step:7:18
Failing tests when no `--cuda` or `--hip`:
```
Clang :: Driver/sycl-offload-amdgcn.cpp
Clang :: Driver/sycl-oneapi-gpu.cpp
Clang :: Driver/sycl-triple-dae-flags.cpp
Clang :: Driver/sycl-unsupported-arch.cpp
Clang :: SemaSYCL/lb_sm_90.cpp
```
I have the feeling these tests should not run in that case or should be updated.
**To Reproduce**
```bash
python3 $DPCPP_HOME/llvm/buildbot/configure.py --shared-libs
python3 $DPCPP_HOME/llvm/buildbot/compile.py --verbose
cmake --build $DPCPP_HOME/llvm/build --target check-clang
```
**Environment (please complete the following information):**
- OS: Ubuntu 23.10
- DPC++ version: today 4d9523715992
Contributor guide
Research direction
Start with the five listed Clang tests and reproduce the failure using buildbot/configure.py, buildbot/compile.py, and the check-clang target without --cuda or --hip. Determine whether the tests should be gated or updated, then verify that check-clang passes in that configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp, python
- Domain
- build-system, compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100