intel / intel/llm-scaler

setup.py uses sys.executable to locate python312.lib, causing build failure in venv

Open
#457 1 comment 0 reactions 1 assignee Claimed by @xiangyuT View on GitHub
Dominant language
C++
Stars
529
Forks
80
Avg merge
9h 7m
Merged PRs (30d)
38

Description

my Python 3.12.10 with virtualenv

bug cause line:
https://github.com/intel/llm-scaler/blob/70ce9e3696cf86ed03f4cb9f497da3ffca3ec77a/omni/omni_xpu_kernel/setup.py#L146

result:
```
sys.executable ==> C:\ComfyUI\venv\Scripts\python.exe
sys.prefix ==> C:\ComfyUI\venv
sys.base_prefix ==> C:\Users\narat\AppData\Local\Programs\Python\Python312
```

so i think we should use this code
`python_lib_dir = str(Path(sys.base_prefix) / "libs")`

i'm not sure, would be good if someone testing this my code
thanks you

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.