intel / intel/libva

Wrong documentation in VASurfaceAttribPixelFormat

Open
#304 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
784
Forks
314
PR merge metrics
No merged PRs in 30d

Description

The documentation for VASurfaceAttribPixelFormat looks like wrong:
https://github.com/intel/libva/blob/master/va/va.h#L1253

/**
* \brief Pixel format (fourcc).
*
* The value is meaningful as input to vaQuerySurfaceAttributes().
* If zero, the driver returns the optimal pixel format for the
* specified config. Otherwise, if non-zero, the value represents
* a pixel format (FOURCC) that is kept as is on output, if the
* driver supports it. Otherwise, the driver sets the value to
* zero and drops the \c VA_SURFACE_ATTRIB_SETTABLE flag.
*/
VASurfaceAttribPixelFormat,

The VASurfaceAttrib in vaQuerySurfaceAttributes() should be **output** argument rather **input**.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.