intel / intel/isa-l

ec_base_aliases.c ec_init_tables() needlessly calls ec_init_tables_base(), which should be renamed to ec_init_tables_sse().

Open
#394 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
1.1k
Forks
346
PR merge metrics
No merged PRs in 30d

Description

ec_base_aliases.c ec_init_tables() needlessly calls ec_init_tables_base().

For ec_base_aliases.c, ec_init_tables() should be an empty function that just returns, since ec_encode_data() calls ec_encode_data_base() which is low level code that operates on 1 byte at a time using lookup tables and doesn't use g_tbls.

ec_init_tables_base() should be renamed to ec_init_tables_sse() or ec_init_tables_pshufb() since that is it's purpose. All of the other _base functions are low level and don't use g_tbls.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.