missing or bad comments regarding constants in crc16_t10dif_01.asm ... 02.asm
- Dominant language
- C
- Stars
- 1.1k
- Forks
- 346
- PR merge metrics
- No merged PRs in 30d
Description
Some of the comments for the RKxx constants are wrong or are missing. Below is set of the constants along with the corrected or missing comments. Note I renamed rk1 -> rk9 to rk01 -> rk09 in the code fragment below.
```
rk01 dq 02d56000000000000h ; 2^(32* 3) mod Q << 32
rk02 dq 006df000000000000h ; 2^(32* 5) mod Q << 32
rk03 dq 09d9d000000000000h ; 2^(32*31) mod Q << 32 (wrong in github asm file)
rk04 dq 07cf5000000000000h ; 2^(32*33) mod Q << 32 (wrong in github asm file)
rk05 dq 02d56000000000000h ; 2^(32* 3) mod Q << 32
rk06 dq 01368000000000000h ; 2^(32* 2) mod Q << 32
rk07 dq 000000001f65a57f8h ; floor(2^64/Q)
rk08 dq 0000000018bb70000h ; Q
rk09 dq 0ceae000000000000h ; 2^(32*27) mod Q << 32
rk10 dq 0bfd6000000000000h ; 2^(32*29) mod Q << 32
rk11 dq 01e16000000000000h ; 2^(32*23) mod Q << 32
rk12 dq 0713c000000000000h ; 2^(32*25) mod Q << 32
rk13 dq 0f7f9000000000000h ; 2^(32*19) mod Q << 32
rk14 dq 080a6000000000000h ; 2^(32*21) mod Q << 32
rk15 dq 0044c000000000000h ; 2^(32*15) mod Q << 32
rk16 dq 0e658000000000000h ; 2^(32*17) mod Q << 32
rk17 dq 0ad18000000000000h ; 2^(32*11) mod Q << 32
rk18 dq 0a497000000000000h ; 2^(32*13) mod Q << 32
rk19 dq 06ee3000000000000h ; 2^(32* 7) mod Q << 32
rk20 dq 0e7b5000000000000h ; 2^(32* 9) mod Q << 32
```
Contributor guide
Assessment
This issue has not been assessed yet.