Please don't fork ipu7 support as a separate repository
- Dominant language
- C
- Stars
- 15
- Forks
- 34
- Avg merge
- 21h 11m
- Merged PRs (30d)
- 1
Description
For the kernel side, the official way to integrate [ipu6-drivers](https://github.com/intel/ipu6-drivers) has always been in-tree builds, and the out-of-tree dkms builds breaks from time to time. Under in-tree builds, you copy related driver source files along with Kconfig/Makefile changes into the kernel tree to be integrated. If there are two such in-tree builds, e.g. one ipu6 and one ipu7, the related files are meant to be conflicting to each other, and actually they (for example, `drivers/media/pci/intel/cio2-bridge.*`) are different right now. Forking kernel drivers with common components is never a good idea. You should really integrate ipu7 drivers into ipu6-drivers instead.
For the userspace side, please always keep in mind that you may have only one instance of a specific file path in the system. For now it appears the [HAL](https://github.com/intel/ipu7-camera-hal) and [bins](https://github.com/intel/ipu7-camera-bins) repositories are empty and [icamerasrc](https://github.com/intel/icamerasrc) is shared with ipu6, but creating a separate repository for HAL and bins has already been sufficient to raise a concern of potential path conflicts.
Contributor guide
Research direction
Start by reviewing the linked ipu6-drivers repository and comparing the in-tree files named in this issue, including drivers/media/pci/intel/cio2-bridge.* and the related Kconfig/Makefile changes. Also inspect the linked HAL, bins, and icamerasrc repositories for the described shared-path concerns. Done means establishing an integration approach that avoids conflicting kernel components and userspace path collisions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100