intel / intel/intel-device-plugins-for-kubernetes
revisit set-version flows
Open
- Dominant language
- Go
- Stars
- 147
- Forks
- 223
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 18
Description
we have `make set-version TAG=` which used to work OK for the purpose it was created but new functionality and usages have added corner cases that makes `set-version` fragile:
- [ ] `make test-with-kind` in `Jenkinsfile` is not covered
- [ ] `ImageMinVersion` is not covered
- [ ] e2e tests for pull requests expect to get the image version from that pull request so we are "patching" `test/e2e/*/*.go`.
This issue is to work on an improved version for setting the image tags in various places.
Contributor guide
Assessment
This issue has not been assessed yet.