intel / intel/hyperscan

Question: clarify the usage of -fno-omit-frame-pointer

Open
#248 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.5k
Forks
816
Avg merge
4d 21h
Merged PRs (30d)
2

Description

For amd64, `-fno-omit-frame-pointer` is set.
https://github.com/intel/hyperscan/blame/master/CMakeLists.txt#L271

We have occasionally removed this flag from build and have hit the bug immediately:
https://github.com/ClickHouse/ClickHouse/pull/11718
because asynchronous stack unwinding from `roseRunProgram` function started to lead to segfault.

I did not find any information about the reason why the flag `-fno-omit-frame-pointer` is required (there is no comments in your CMakeLists.txt file).

My hypothesis is the following:
> It looks like that computed gotos in Hyperscan jumps into the code of different functions and back. And without saving frame pointer, unwinding cannot work.

Am I right?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.