intel / intel/gprofiler

tests: Ensure profiler_type is defined in all tests

Open
#484 0 comments 0 reactions 0 assignees View on GitHub
enhancement refactor
Dominant language
Python
Stars
826
Forks
79
PR merge metrics
No merged PRs in 30d

Description

See my description in [this](https://github.com/Granulate/gprofiler/pull/451/files#r975877845) comment, specifically point 3. Tests are hardcoding the profiler type, but in some cases, the infra needs to know which profiler is going to be used, because it affects the way we will run the profiled application (the case is `nodejs` where depending on the profiler we will run the process with different flags).
If all tests were to define it properly, we could just use the `profiler_type` fixture.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.