intel / intel/confidential-computing.tdx.tdx-module

Question Regarding TDX Module's Use of advance_guest_rip

Open
#10 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
113
Forks
24
PR merge metrics
No merged PRs in 30d

Description


Description:

I have identified a redundant invocation of the advance_guest_rip() function across the files tdg_vp_vmcall.c, td_exit.c, and tdx_vmm_dispatcher.c. Specifically, when td_vmexit_to_vmm(...false, true) is called, both the conditions if (!is_td_dead) and if (is_trap_exit) are met, leading to a call to advance_guest_rip(). On this execution path, tdx_vmm_post_dispatching also unconditionally calls advance_guest_rip(), resulting in the function being executed twice in the same context.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.